W3C home > Mailing lists > Public > public-css-testsuite@w3.org > December 2014

Re: [css-grid] grid-vertical-align-001 and grid-inline-vertical-align-001: review request

From: Manuel Rego Casasnovas <rego@igalia.com>
Date: Tue, 09 Dec 2014 16:18:18 +0100
Message-ID: <548712BA.7090805@igalia.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
CC: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Hi Gérard,

thanks for the detailed review.

On 08/12/14 03:02, Gérard Talbot wrote:
> I did not understand why you needed to use empty inline-blocks in your
> code. Maybe what you coded was okay... I don't know for sure.

Yeah, you're right I like much more your approach, so I've modified the
tests, you can take a look to the new versions at:

* grid-vertical-align-001:
  * Source:
https://github.com/mrego/csswg-test/blob/css-grid-vertical-align-tests/css-grid-1/grid-model/grid-vertical-align-001.xht
  * View:
https://rawgit.com/mrego/csswg-test/css-grid-vertical-align-tests/css-grid-1/grid-model/grid-vertical-align-001.xht

* grid-inline-vertical-align-001:
  * Source:
https://github.com/mrego/csswg-test/blob/css-grid-vertical-align-tests/css-grid-1/grid-model/grid-inline-vertical-align-001.xht
  * View:
https://rawgit.com/mrego/csswg-test/css-grid-vertical-align-tests/css-grid-1/grid-model/grid-inline-vertical-align-001.xht

> Ideally, we always want test to fail when a property or property value
> is not supported or not implemented.

Ups, I didn't realize before. I've modified it following a similar
approach to previous tests. I understand that it should fail if it's not
supported, so the new version will fail in that case.

* grid-display-grid-001.xht:
  * Source:
https://github.com/mrego/csswg-test/blob/css-grid-fix-display-grid-test/css-grid-1/grid-model/grid-display-grid-001.xht
  * View:
https://rawgit.com/mrego/csswg-test/css-grid-fix-display-grid-test/css-grid-1/grid-model/grid-display-grid-001.xht

Please tell me if you're ok with the change.

Cheers,
  Rego
Received on Tuesday, 9 December 2014 15:18:50 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 21:13:27 UTC