- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Sun, 06 Apr 2014 18:30:11 -0400
- To: Public CSS Test suite mailing list <public-css-testsuite@w3.org>, "Shiozawa, Hajime" <hajime.shiozawa@gmail.com>
- Cc: Koji Ishii <kojiishi@gluesoft.co.jp>
Hajime, I did a quick checking of writing-modes tests recently. Here's some feedback 1- http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/inline-block-alignment-001.xht I believe that at line 78: <div class="control" id="control1">LLLL<span>ABCD</span></div> should be instead <div class="control" id="control1">LLLL<span>LLLLL</span></div> I believe such inline-block-alignment-001.xht test should be broken into 6 smaller tests. For best test checking, you want a test to require a viewport height of 400px or less. This is for test checking under the test harness. ------------ 2- http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/vertical-alignment-022.xht <img class="line" src="./support/blue-horiz-line_220x1.png" alt="Image download support must be enabled" /> is incorrect: it should be blue-horiz-line-220x1.png underscore character should be hyphen character. ------------ 3- http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/inline-block-alignment-006-rl.xht There are 3 orange rectangles, not 2 orange rectangles. ------------ 4- http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/text-baseline-006-lr.xht This test seems incorrect. If "central baseline is used as the dominant baseline", then all glyphs of different font-size should be "sitting" on such central baseline; therefore at line 42 'vertical-align: text-top' can not be correct, can not fit into the logic of that test. By replacing the glyphs in the test with "É" glyphs, I am 99% sure that 'vertical-align: text-top' should be removed. +CC: Koji Ishii Gérard -- Web authors' contributions to CSS 2.1 test suite http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html CSS 2.1 Test suite RC6, March 23rd 2011 http://test.csswg.org/suites/css2.1/20110323/html4/toc.html
Received on Sunday, 6 April 2014 22:30:48 UTC