W3C home > Mailing lists > Public > public-css-testsuite@w3.org > March 2013

Re: [writing-modes] text-combine-horizontal-01[0-2].xht and text-orientation-01[0-1].xht and and mplus-1p-regular.woff webfont

From: taka <takaoshiyama@gmail.com>
Date: Tue, 19 Mar 2013 15:35:49 +0900
Message-ID: <51480745.1070409@gmail.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
CC: Public CSS test suite mailing list <public-css-testsuite@w3.org>
Gerard
Please review again as I have corrected/updated by reflecting your 
useful comments.
-> http://hg.csswg.org/test/rev/aea1c3276a0c

regards,

(2013/03/15 15:12), "Gérard Talbot" wrote:
> Taka,
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-combine-horizontal-010.xht
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-combine-horizontal-011.xht
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-combine-horizontal-012.xht
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-010.xht
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-011.xht
>
>
> All these 5 tests should be linking to mplus-1p-regular.woff . You see,
> DejaVuSerifBook is linked to DejaVuSerif-webfont.woff which uses only
> the English subset of DejaVu Serif and it does not support Japanese
> glyphs at all. Anyway, you did not put DejaVuSerif-webfont.woff in your
> /support/ folder.
>
> If a font can not render some glyphs in a particular language, then the
> browser will try to find a suitable font instead capable of rendering
> such glyphs. This is what happens in my browsers.
>
> In all those 5 tests, for now, please replace
>
>   @font-face {
>   font-family: "DejaVuSerifBook";
>   src: url("support/DejaVuSerif-webfont.woff") format("woff");
>   /* Filesize: 18096 bytes (17.7 KBytes) */
>   }
>
> with
>
>   @font-face
>   {
>   font-family: "mplus-1p-regular";
>   src: url("support/mplus-1p-regular.woff") format("woff");
>   /* filesize: 803300 bytes (784.5 KBytes) */
>   /*
>   mplus-1p-regular.ttf can be downloaded at/from [TBD later]
>   */
>   }
Okay, I returned to font-family: "mplus-1p-regular", thanks.
> Copy mplus-1p-regular.woff
> from
> http://www.gtalbot.org/BrowserBugsSection/review/support/
> in your
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/support/
Yes, I did.
>
> You should extend those changes also to their associated reftests.
Yes, I did.
> --------------
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-011.xht
>
>
> line 64: text-combine: horizontal;
>
> I do not see this property in CSS3 writing-mode spec.
I removed two lines. (I placed text-combine: horizontal; in #control for 
reference as this property is obsolete, yet still effective on webkit 
based browsers.)
>
> ------------
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-012.xht
>
> and
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-014.xht
>
> and
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/reftest/text-orientation-014-ref.xht
>
> line 54: text-combine: none;
>
> This declaration is going to be ignored. I do not see why it should be
> there.
I removed two lines. (I placed text-combine: none; in #control for 
reference as this property is obsolete, yet still effective on webkit 
based browsers.)
> ------------
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-013.xht
>
> and
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-014.xht
>
> and
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-015.xht
>
>
> line 10: <meta name="flags" content="ahem font" />
>
> to replace with
>
> line 10: <meta name="flags" content="ahem" />
>
> since these tests do not require a particular font like "DejaVu Serif"
> or "mplus-1p-regular"
I dropped "font".
> ------------
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/reftest/text-orientation-013-ref.xht
>
> 		<div id="control_ahem"> 63
>   52
> 7 1</div>
> 		<div id="control_ahem"> 63
>
> should be replaced with
>
> 		<div class="control_ahem"> 63
>   52
> 7 1</div>
> 		<div class="control_ahem"> 63
>
I changed to class as it was my careless mistake.
> ------------
>
> In
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/reftest/text-orientation-010-ref.xht
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/reftest/text-orientation-011-ref.xht
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/reftest/text-orientation-012-ref.xht
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/reftest/text-orientation-013-ref.xht
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/reftest/text-orientation-014-ref.xht
>
> please remove
>
>          .test
>
> and
>
> 	.test_ahem
>
> CSS rules. Since those are only useful in tests. They are not used in
> reftests.
yes, I removed.
> ------------
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/reftest/text-orientation-015-ref.xht
>
> .test_ahem	{
> 		text-orientation: sideways;				//The property to be tested
> 		-webkit-text-orientation: sideways;
> 		writing-mode: vertical-lr;
> 		-webkit-writing-mode: vertical-lr;
> 		}
>
> should be removed.
Yes, I removed.
>
> ------------
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-combine-horizontal-012.xht
>
> line 34: text-combine-horizontal: digits 1;
>
> "Removed all ‘text-combine-horizontal’ values except ‘none’ and ‘all’."
> http://www.w3.org/TR/css3-writing-modes/#recent-changes
>
I withdrew 'text-combine-horizontal-012.xht' and its reftest as the 
value "digits" no longer exists.
> ------------
>
> In several of your text-orientation-01?.xht reftests, you used many
> declarations for the control element. What you did is correct. I
> personally would have created an image instead.
>
> Eg
>
> http://www.gtalbot.org/BrowserBugsSection/review/text-orientation-015-ref-review.xht
>
> uses only 2 elements and 2 declarations. It also applies the principle
> of using another, different method for the reftest.
Thank you. I will be able to use as my reference.
> "
> The reference file must not use the same features that are being tested.
> "
> http://wiki.csswg.org/test/reftest#components-of-a-reftest
>
> Gérard


-- 


taka oshiyama 押山 隆
takaoshiyama@gmail.com
Received on Tuesday, 19 March 2013 06:36:20 GMT

This archive was generated by hypermail 2.3.1 : Tuesday, 19 March 2013 06:36:23 GMT