Re: css3 line-break tests

On Mon, Jan 21, 2013 at 9:36 PM, "Gérard Talbot" <css21testsuite@gtalbot.org
> wrote:

>
> Le Lun 21 janvier 2013 21:28, Glenn Adams a écrit :
> > FYI, I intend to submit a number of tests related to the CSS3 line-break
> > property, particularly those that relate to testing the functionality or
> > fixes deriving from:
> >
> > [1] https://bugs.webkit.org/show_bug.cgi?id=89235
> > [2] https://bugs.webkit.org/show_bug.cgi?id=105692
> >
> > Some preliminary reftests have already been included in [3], but need to
> > be
> > finalized and retargeted for the CSS test suite format.
> >
> > [3] https://bugs.webkit.org/attachment.cgi?id=172397&action=prettypatch
> >
> > Regards,
> > Glenn
>
> Glenn,
>
> I suggest to make single, unique tests and not a test made of 3 single
> tests.
>
> Avoid using the word "box" in the description; for most people, a box is
> a 3-dimension object.
>
> If you refer to identical rendering, then shape and size of rectangle
> should be identical and content of rectangle should be identical.
>
> From bug report https://bugs.webkit.org/show_bug.cgi?id=105692
>
> Test:
> https://bug-105692-attachments.webkit.org/attachment.cgi?id=180625
>
> Expected result:
> https://bug-105692-attachments.webkit.org/attachment.cgi?id=182513
>
> is not what I would have understood or expected by 3 identical pairs of
> boxes.
>

Thanks for that input. Regarding the term 'box', I disagree with you that
it should be avoided. The term has a well defined meaning in CSS [1] that
is not a 3 dimensional object. We can't very well and go retrofit the
fundamental CSS concepts here, I'm sure you'll agree.

[1] http://www.w3.org/TR/CSS2/box.html