W3C home > Mailing lists > Public > public-css-testsuite@w3.org > February 2013

Re: Comments on text-orientation-010.xht

From: taka <takaoshiyama@gmail.com>
Date: Sat, 23 Feb 2013 13:40:02 +0900
Message-ID: <51284822.2040109@gmail.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
CC: Public CSS test suite mailing list <public-css-testsuite@w3.org>
Hi Gerard
I would appreciate your kind review as I have corrected each.
http://hg.csswg.org/test/rev/ad09f8d944fe

regards, from taka

(2013/02/23 6:29), "Gérard Talbot" wrote:
> Le Ven 22 février 2013 8:57, taka a écrit :
>> Hi Gerard
>> As I have updated the files, I would appreciate your kind review.
>> http://hg.csswg.org/test/rev/746607480c9c
>>
>> regards, from taka
>> (2013/02/22 6:57), "Gérard Talbot" wrote:
>>> Taka,
>>>
>>> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-010.xht
>>>
>>> 1.
>>> If you use Ahem font in a test, then you have to add, to declare
>>> "ahem"
>>> flag.
>>>
>>> "ahem 	Requires the Ahem font"
>>> http://wiki.csswg.org/test/format#requirement-flags
>> yes, I declared.
>>> 2.
>>> line 10: <meta name="flags" content="font should" />
>>> You can remove the "should" flag.
>> yes, I corrected.
>
>
> "[ ] Requirement flags are in alphabetical order."
> http://wiki.csswg.org/test/css2.1/review-checklist#nitpicky
>
>
> So,
> <meta name="flags" content="font ahem" />
> should be
> <meta name="flags" content="ahem font" />
Okay, I changed the order.
>
>>> 3.
>>> Here, I think you should split such text-orientation-010.xht test in 2
>>> sub-tests. vertical writing mode and special text-orientation features
>>> are difficult for most Westerners.
>> no, I believe not split and keeping two sub-test to a single testcase
>> make sense as the test consists of a pair of sub-tests and complements
>> each other.
>> Logically, the test should verify 1.block flow direction, 2.inline
>> direction and 3.glyph orientation. The "Ahem" test comes first and
>> checks 1. and 2. , whereas "glyph" test comes later and supplementary
>> checks 3.
>> Also, the view area of this test can fit into relatively small screen
>> size, no need to split from view size point of view.
>
> Taka,
>
> This is interesting explanations from you, test creator, about your test
> page and why it is what+how it is. Maybe add a <!-- comment -->
> somewhere in the test for reviewers and user agent implementers.
>
> I suggest
>
> <!--
> This test consists of a pair of sub-tests which complements each other.
> Logically, the test should verify 1.block flow direction, 2.inline
> direction and 3.glyph orientation. The "Ahem" sub-test comes first and
> checks 1. and 2. , whereas "glyph" sub-test comes later and also
> checks 3.
> -->
>
> In general, we prefer shorter tests and tests targeting well defined
> features. But there are exceptions and situations where this is not
> possible to do.
Thank you, and I added this as a comment in each.
>
> Gérard


-- 


taka oshiyama 押山 隆
takaoshiyama@gmail.com
Received on Saturday, 23 February 2013 04:40:36 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Saturday, 23 February 2013 04:40:40 GMT