W3C home > Mailing lists > Public > public-css-testsuite@w3.org > February 2013

Re: Comments on text-orientation-010.xht

From: taka <takaoshiyama@gmail.com>
Date: Fri, 22 Feb 2013 22:57:19 +0900
Message-ID: <5127793F.4060501@gmail.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
CC: Public CSS test suite mailing list <public-css-testsuite@w3.org>
Hi Gerard
As I have updated the files, I would appreciate your kind review.
http://hg.csswg.org/test/rev/746607480c9c

regards, from taka
(2013/02/22 6:57), "Gérard Talbot" wrote:
> Taka,
>
> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-orientation-010.xht
>
> 1.
> If you use Ahem font in a test, then you have to add, to declare "ahem"
> flag.
>
> "ahem 	Requires the Ahem font"
> http://wiki.csswg.org/test/format#requirement-flags
yes, I declared.
>
> 2.
> line 10: <meta name="flags" content="font should" />
> You can remove the "should" flag.
yes, I corrected.
> 3.
> Here, I think you should split such text-orientation-010.xht test in 2
> sub-tests. vertical writing mode and special text-orientation features
> are difficult for most Westerners.
no, I believe not split and keeping two sub-test to a single testcase 
make sense as the test consists of a pair of sub-tests and complements 
each other.
Logically, the test should verify 1.block flow direction, 2.inline 
direction and 3.glyph orientation. The "Ahem" test comes first and 
checks 1. and 2. , whereas "glyph" test comes later and supplementary 
checks 3.
Also, the view area of this test can fit into relatively small screen 
size, no need to split from view size point of view.
> 4.
> 	<div class="view" lang="ja"><span
> class="test">&#26376;&#28779;&#27700;Abc<br
> />def&#26408;&#37329;&#22303;</span></div><br />
> 	<div class="view" lang="ja"><span
> class="control">&#26376;&#28779;&#27700;Abc<br
> />def&#26408;&#37329;&#22303;</span></div>
>
> The <br /> presence (between </div> and <div ...>) is not valid HTML.
> You can just add a margin-bottom declaration to div.view instead
yes, I fixed it.
>
> 5.
> line 54: text-orientaion: mixed; //The property to be tested
>
> it should be text-orientation: mixed;
Sorry, I fixed this typo.
> 6.
> <title>CSS3 Writing Modes Test: text-orientation-mixed</title>
>
> should be instead
>
> <title>CSS Writing Modes Test: text-orientation - mixed</title>
yes, I fixed.
>
> Gérard


-- 


taka oshiyama 押山 隆
takaoshiyama@gmail.com
Received on Friday, 22 February 2013 13:57:56 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 22 February 2013 13:58:00 GMT