W3C home > Mailing lists > Public > public-css-testsuite@w3.org > August 2013

Re: [css3-multicol] Problems with multicol-fill-002

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Sat, 3 Aug 2013 01:47:52 -0400
Message-ID: <cc6f8f7ace9e54f255a958d11c45369f.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Håkon Wium Lie" <howcome@opera.com>
Cc: "Public css-testsuite mailing list" <public-css-testsuite@w3.org>

Le Sam 3 août 2013 1:03, Håkon Wium Lie a écrit :
> Based on your comments below, I have tried to re-engineer the test. I
> propose:
>
>   http://people.opera.com/howcome/2013/tests/multicol/column-fill-auto.html
>   http://people.opera.com/howcome/2013/tests/multicol/column-fill-balance.html


Those are excellent tests, simplified and minimalist. Albeit

1-
line 13: font-size: 1em;
should be replaced with
font-size: 1.25em;
so that computed font-size value can be dividable by 5px, otherwise
baseline-alignment of glyphs won't be reliable, won't be accurate across
platforms.

2-
line 18: overflow: hidden;

Why overflow: hidden? This declaration is not needed, not necessary in
both tests.

3-
line 19: background: transparent;

By default, the initial value is already transparent. So, here too: not
needed and not necessary in both tests.

4-
I would re-use the same distinguishible 'o' and 't' characters in both
tests; this would furthermore highlight and accentuate the code
difference between the tests.

Gérard

> (The tests have a build-in reftest, separate reftest files should be
> extracted once we agree on the tests themselves.)
>
> -h&kon
>               Håkon Wium Lie                          CTO °þe®ª
> howcome@opera.com                  http://people.opera.com/howcome
>
>
> Gérard Talbot wrote:
>
>  > [src]
>  > http://test.csswg.org/source/contributors/opera/submitted/multicol/multicol-fill-002.xht
>  >
>  > [reftest]
>  > http://test.csswg.org/source/contributors/opera/submitted/multicol/multicol-fill-ref.xht
>  >
>  > 1-
>  > The filename should be renamed to multicol-fill-balance-001.xht .
> That
>  > way, a set of tests testing 'column-fill: balance' would be easier to
>  > find/get.
>  >
>  > 2-
>  > The test in its current version passes in UAs which do not support
>  > multi-column.
>  >
>  > 3-
>  > Computed font-size of multi-column element should be dividable by 5px
>  > without remainer in order to be accurate and reliable across
> platform.
>  >
>  > 4-
>  > The most important problem with the test is that the test is not
> truly
>  > creating the appropriate, suitable conditions where 'column-fill:
>  > balance' would create a rendering different from 'column-fill: auto'.
> If
>  > the test was good, then the test, in my opinion, should fail and fail
> in
>  > a predictable manner if an UA does not support 'column-fill: balance'
>  > and only support 'column-fill: auto'. Here, the test passes if
>  > 'column-fill: balance' is removed!
>  >
>  > If all the inline content is expected to fill each line and to fill
> each
>  > column box, then there is no predictable difference to be expected
> when
>  > setting 'column-fill: balance' or when setting 'column-fill: auto'.
>  >
>  > So, ideally, a test testing 'column-fill: balance' versus
> 'column-fill:
>  > auto' needs to create not too much inline content so that it can and
>  > will only fill half of all column boxes and then verify that all
> inline
>  > content fills all column boxes but only half of them (column-fill:
>  > balance) as compared to filling half of all column boxes
> (column-fill:
>  > auto).
>  >
>  > Imagine something like:
>  >
>  > div
>  > {
>  > column-count: 2;
>  > column-gap: 1em;
>  > height: 6em;
>  > width: 21em;
>  > }
>  >
>  > where digits represents single characters
>  >
>  > <div>1234567890 12 4567 90 123 56 890 123 56789 1 34567 90 12 4567 90
>  > 123 56 890 123 56</div>
>  >
>  > with 'column-fill: balance':
>  > ------------  ------------
>  > |1234567890|  |1 34567 90|
>  > |12 4567 90|  |12 4567 90|
>  > |123 56 890|  |123 56 890|
>  > |123 56789 |  |123 56    |
>  > |          |  |          |
>  > |          |  |          |
>  > ------------  ------------
>  >
>  > Same inline content with 'colum-fill: auto':
>  > ------------  ------------
>  > |1234567890|  |123 56 890|
>  > |12 4567 90|  |123 56    |
>  > |123 56 890|  |          |
>  > |123 56789 |  |          |
>  > |1 34567 90|  |          |
>  > |12 4567 90|  |          |
>  > ------------  ------------
>  >
>  > In conclusion, testing 'column-fill: balance' versus 'column-fill:
> auto'
>  > requires less content to fill the column boxes, shorter words
> (versus)
>  > large column boxes. That way, the test provides a leeway where both
>  > column-fill values can "express" their characteristics.
>  >
>  > Gérard
>  > --
>  > Contributions to the CSS 2.1 test suite:
>  > http://www.gtalbot.org/BrowserBugsSection/css21testsuite/
>  >
>  > CSS 2.1 Test suite RC6, March 23rd 2011:
>  > http://test.csswg.org/suites/css2.1/20110323/html4/toc.html
>  >
>  > CSS 2.1 test suite harness:
>  > http://test.csswg.org/harness/
>  >
>  > Contributing to to CSS 2.1 test suite:
>  > http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
>
>


-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Saturday, 3 August 2013 05:48:21 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 21:13:26 UTC