W3C home > Mailing lists > Public > public-css-testsuite@w3.org > April 2013

Review of Opera's multicolumn tests

From: Simon Pieters <simonp@opera.com>
Date: Thu, 11 Apr 2013 16:18:18 +0200
To: "W3C CSS Test Suite" <public-css-testsuite@w3.org>
Message-ID: <op.wvdrcsigidj3kv@simons-macbook-pro.local>
Review of

http://test.csswg.org/shepherd/search/spec/CSS3-MULTICOL/owner/oyvind/status/submitted/status/updated/status/issue/status/spec/status/rejected/load/t98/


It would be useful if each test had a distinct and more descriptive title.


multicol-collapsing-001.xht multicol-collapsing-ref.xht

This one seems wrong. It expects the top margin of h6 to collapse, but the  
spec says:

[[
A multi-column element establishes a new block formatting context, as per  
CSS 2.1 section 9.4.1.
Example XI

A top margin set on the first child element of a multicol element will not  
collapse with the margins of the multicol element.
]]


multicol-columns-toolong-001.xht

This has a paragraph that is not present in the ref. It should be removed.


multicol-gap-001.xht multicol-gap-ref.xht

I don't understand why the ref has the fourth column empty?


multicol-rule-large-002.xht

Is this a manual test? Maybe non-reftests should be separated more  
clearly, e.g. different folder?

Does the spec say that there should be no scrollbar?


multicol-rule-px-001.xht

This has some rulesets that don't apply which should probably be removed.


That's all I had.

-- 
Simon Pieters
Opera Software
Received on Thursday, 11 April 2013 14:18:53 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 21:13:26 UTC