W3C home > Mailing lists > Public > public-css-testsuite@w3.org > November 2012

RE: background-size-026, 027 need approval, review; reftest for background-334

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Tue, 20 Nov 2012 22:48:43 -0500
Message-ID: <f9ad11e863d754909198395cb6d3cc17.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Zhang, Zhiqiang" <zhiqiang.zhang@intel.com>
Cc: "Public CSS testsuite mailing list@w3.org" <public-css-testsuite@w3.org>, "Santos, Thiago" <thiago.santos@intel.com>, "Zhang, Haili" <haili.zhang@intel.com>, "Yu, Ling L" <ling.l.yu@intel.com>, "Yang, Lei A" <lei.a.yang@intel.com>

Le Mar 20 novembre 2012 22:27, Zhang, Zhiqiang a écrit :
>> -----Original Message-----
>> From: "Gérard Talbot" [mailto:css21testsuite@gtalbot.org]
>> Sent: Wednesday, November 21, 2012 10:58 AM
>> To: Zhang, Zhiqiang
>> Cc: Public CSS testsuite mailing list@w3.org; Santos, Thiago; Zhang,
>> Haili; Yu,
>> Ling L; Yang, Lei A
>> Subject: Re: background-size-026, 027 need approval, review; reftest
>> for
>> background-334
>>
>
>
>> >> Proposed replacement
>> >> --------------------
>> >>
>> >> http://www.gtalbot.org/BrowserBugsSection/review/background-size-
>> 027-
>> >> review.html
>> >>
>> >
>> > For background-size-027, as the test says "the width of the
>> background
>> > image is 52px" and won't be rounded to 60p, so I changed background
>> > width to 156px from 180px in order to easily create a reftest (by
>> > copying background-size-029-ref.xht and changing img width to 52px).
>> And
>> > I have to use "rectangles" instead of " squares". Please review it
>> > again, thanks.
>>
>> Hmm... This is something tests should be trying to avoid (as a general
>> rule): creating irregular shapes like a 60px tall by 52px wide
>> rectangles. A 2:1 rectangle (say, 100px wide by 50px tall) is usually
>> easy to recognize, but a 60 by 52 isn't easy to recognize...
>> I guess we'll make an exception here since there is a reftest for this
>> test.
>>
>> I have updated + uploaded
>> http://www.gtalbot.org/BrowserBugsSection/review/background-size-027-
>> review.html
>
> This test involves a 4th column blue-to-orange rectangles ( 3 60px tall
> by 24px wide), :) Opera 12.11 shows it.


That's correct. It's because of 'background-repeat: repeat round'. I had
"<p>Test passes if there is 3 rows of 3 blue-to-orange rectangles and if
there is <strong>no partially</strong> displayed rectangles below the
3rd row and <strong>no red</strong>.</p>"

and so it was okay to see partially displayed rectangles on the right of
3rd column.


I mis-read what you did. You changed 180px to 156px. This can be done too.

I have modified

http://www.gtalbot.org/BrowserBugsSection/review/background-size-027-
review.html

to match your test. What you do simplifies the task of the tester.

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Wednesday, 21 November 2012 03:49:16 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Wednesday, 21 November 2012 03:49:17 GMT