W3C home > Mailing lists > Public > public-css-testsuite@w3.org > November 2012

Re: background-size-contain/cover (RE: background-size-003 review)

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Thu, 8 Nov 2012 20:52:02 -0500
Message-ID: <05bb1047c8d79ae05944fa408c77b8f6.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Zhang, Zhiqiang" <zhiqiang.zhang@intel.com>
Cc: "Public CSS testsuite mailing list@w3.org" <public-css-testsuite@w3.org>, "Christensen, Kenneth" <kenneth.christensen@intel.com>, "Zhang, Haili" <haili.zhang@intel.com>, "Yu, Ling L" <ling.l.yu@intel.com>, "Yang, Lei A" <lei.a.yang@intel.com>

Le Mer 7 novembre 2012 20:27, Zhang, Zhiqiang a écrit :


> I added one test to check background-repeat 'round' value,
> because I found currently no browser supports this feature when I
> refined tests background-size-025, 027, 029, 031. Correct me if am
> wrong.
>
> http://test.csswg.org/source/contributors/intel/submitted/css3-background/background-repeat-round-001.html


Zhiqiang,

One important pass/fail conditions in this test is about partially
displayed images or clipped (sliced) images. The pass/fail conditions
sentences should state that partially displayed cat images or sliced
images must be considered as a test failure.

Also, "2x2 cat image" may be a bit confusing to some people...
furthermore if "image" in that sentence is singular, not plural. Hmm..
And a single <img> could have 2 cats.


How about

Test passes if there is 2 rows of 2 cat images, with no clipped (sliced)
cat image and no red.

or

Test passes if there is 2 rows of 2 cat images and if there is no
clipped (sliced) cat image and no red.


Another idea is to drop the reference to "image" and remove the usage of
the word "image" in such sentence. This is furthermore relevant because
it is often impossible to know how many <img> there are in a webpage
without examining the source code. So,



Test passes if there is 2 rows of 2 cats, with no clipped (sliced) cat
and no red.

or

Test passes if there is 2 rows of 2 cats and if there is no clipped
(sliced) cat and no red.



----------


If the whole test only requires one element, then it is not really
necessary to identify it with the id attribute id="test".

line 10:  div {
line 27:  <div></div>

is okay.

id="test" is best used when it is necessary to declare its counter-part:
like id="control" or id="reference"


Overall, this background-repeat-round-001.html test is excellent!

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Friday, 9 November 2012 01:52:36 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 9 November 2012 01:52:38 GMT