W3C home > Mailing lists > Public > public-css-testsuite@w3.org > May 2012

Reftest filename convention; multicol-rule-inset-000; small issues

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Wed, 16 May 2012 14:54:32 -0400
Message-ID: <f9514b121754b03ad98e7745b0f820f9.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>
Cc: "Håkon Wium Lie" <howcome@opera.com>
Hello,

"
References should be named after the earliest test that uses them in the
test-topic series they belong to, and must have either -ref or -notref
appended to the name.
"
http://wiki.csswg.org/test/reftest#the-reftest-reference-file

So, such filename convention means, implies that
http://test.csswg.org/suites/css3-multicol/nightly-unstable/html4/height-block-child-001.htm
associated reftest should be filenamed
height-block-child-001-ref.htm

------------

http://test.csswg.org/suites/css3-multicol/nightly-unstable/html4/multicol-rule-inset-000.htm

In my opinion, the only reason why Opera 11.64 fails this test is
related to how 'border-style: inset' works.

I think the test will cause a false negative. Suggestion: inset replaced
by solid

------------

Other small issues:

1- In my opinion, the best pass-fail-condition sentence is/starts with:

"Test passes if [...]".

2- Since all tests starts with a pass-fail-condition sentence, then
there is no need to use "below", "following", "under this paragraph" or
similar meaning in the pass-fail-condition sentence.

3- Extraneous declarations (or elements) or unnecessary declarations (or
elements) should be avoided.
"The test contains no extraneous content."
http://wiki.csswg.org/test/css2.1/review-checklist#test-design
I see this occuring in reftests too.

4- Many tests (not just in the multicol test suite) use
'border-collapse: collapse' for HTML tables (and sub-table elements)
which do not even have borders. The implicit goal for doing this is to
neutralize border-spacing default UA value (2px 2px) effect in the
'border-collapse: separate' model. This, in my opinion, is awkward; it
may be valid but it's not context-logical. I suggest to use
'border-spacing: 0px' instead/rather than 'border-collapse: collapse' in
such cases.

5- Some tests have markup validation issues. Eg.
http://test.csswg.org/suites/css3-multicol/nightly-unstable/html4/multicol-rule-000.htm
only needs to wrap the pass-fail-condition sentence into a <p>...</p>
in this case, at line 30.

6- Many tests may need to be filename-renamed. Eg.
http://test.csswg.org/suites/css3-multicol/nightly-unstable/html4/height-001.htm
height-001 does not seem to be the best filename for this test. I believe
multicol-height-001 may be better here.

7-
"
Declarations are listed in a consistent order throughout a test series.
(Always listing properties in alphabetical order makes this easy.)
"
http://wiki.csswg.org/test/css2.1/review-checklist#nitpicky

This actually helps review, reviewing, code examination by others not
familiar with the tests. It also helps when selectors are listed in the
order taken by document.

8- Many tests use Ahem font; sometimes, I am not sure why or do not see
why (just a prelimary/superficial impression).

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Wednesday, 16 May 2012 18:55:05 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Wednesday, 16 May 2012 18:55:14 GMT