W3C home > Mailing lists > Public > public-css-testsuite@w3.org > March 2012

Re: [RC6] font-family-name-023

From: John Daggett <jdaggett@mozilla.com>
Date: Sat, 17 Mar 2012 19:44:49 -0700 (PDT)
To: css21testsuite@gtalbot.org
Cc: Public CSS test suite mailing list <public-css-testsuite@w3.org>
Message-ID: <1062516325.12959340.1332038689708.JavaMail.root@zimbra1.shared.sjc1.mozilla.com>

Hi Gérard,

I still see no reason for the changes you propose.  Neither the tests
or assertion are incorrect.  The misinterpretation seems to be based
on mixing up 'font' and 'font-family'.  If you were confused about the purpose
of the test, then adding a comment would be fine.

Cheers,

John

----- Original Message -----
From: "Gérard Talbot" <css21testsuite@gtalbot.org>
To: "John Daggett" <jdaggett@mozilla.com>
Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>
Sent: Saturday, March 17, 2012 4:37:27 PM
Subject: Re: [RC6] font-family-name-023


Le Sam 17 mars 2012 3:17, John Daggett a écrit :
> Gérard Talbot wrote:
>
>> The reftest for font-family-name-023 does not use the font-family
>> "x-large CSSTest FamilyName Funky" but rather "CSSTest FamilyName".
>
> Huh?
>
> These are the property definitions used in that test:
>
>   p#test1a {
>       font-family: "small-caps 1in CSSTest FamilyName Funky", CSSTest
> Fallback;
>   }
>   p#test2 {
>       font-family: x-large CSSTest FamilyName Funky, CSSTest Fallback;
>   }
>   p#test2a {
>       font-family: "x-large CSSTest FamilyName Funky", CSSTest Fallback;
>   }
>   p#test3a {
>       font-family: "12px CSSTest FamilyName Funky", CSSTest Fallback;
>   }
>
> The font named "CSSTest FamilyName" is *not* used for this test!!!

John,

I understand that the font named "CSSTest FamilyName" is *not* used for
this test. Albeit 4 hours ago, I did not.

> Remember, those are 'font-family' definitions *not* 'font' definitions.


I understand.

>
> John


The *reftest* for font-family-023 uses "CSSTest FamilyName" for the 4
tests. Doing so (choosing that precise font family name) certainly can
lead to misinterpretation of what the test is doing or trying to
demonstate.

This sentence "Font family names that appear similar to font shorthand
should match to fonts with those names" is rather vague and open to
interpretation ..


Proposal for the *reftest*
http://test.csswg.org/source/contributors/mozilla/submitted/fontreftests/font-family-name-023-ref.xht


        <style type="text/css">
            body { font-size: 36px; }
            span#verify { font-family: CSSTest Verify; }

            p#test1a {
                font-family: "small-caps 1in CSSTest FamilyName Funky";
            }
            p#test2, p#test2a {
                font-family: "x-large CSSTest FamilyName Funky";
            }

            p#test3a {
                font-family: "12px CSSTest FamilyName Funky";
            }
        </style>
    </head>
    <body>
        <div><a href="http://www.w3.org/Style/CSS/Test/Fonts/">Test
fonts</a> must be installed for this test: <span
id="verify">FAIL</span></div>
        <p id="test1a">PaSs</p>
        <p id="test2">PaSs</p>
        <p id="test2a">PaSs</p>
        <p id="test3a">PaSs</p>



Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Sunday, 18 March 2012 02:45:19 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Sunday, 18 March 2012 02:45:25 GMT