W3C home > Mailing lists > Public > public-css-testsuite@w3.org > March 2012

[RC6] containing-block-017 : proposed improvements

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Fri, 9 Mar 2012 16:31:23 -0500
Message-ID: <fc7d9c6cfab1fa3fa1110a98cc590866.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Alan Gresley" <alan@css-class.com>, "Arron Eicholz" <arron.eicholz@microsoft.com>
Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>
Arron and Alan,

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/containing-block-017.htm

[nightly-unstable]
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/containing-block-017.htm


1- I do not see/do not understand why

            #tl-control
            {
                border-top: 30px solid red;
                margin-left: -50px;
line 34         margin-right: 20px;
                padding: 20px 15px;
            }
            #br-control
            {
                border-bottom: 30px solid red;
line 40         margin-left: 20px;
                margin-right: -50px;
                padding: 20px 15px;
            }

these 2 declarations should apply, are useful or are related to the
purpose of the test.

2-
The test title, meta assert text and meta flag should be updated to
reflect what the test is trying to do exactly and some updates to the
spec. I propose the following:

<title>CSS Test: Containing Block - absolutely positioned element versus
nearest positioned ('position: relative') ancestor which is an inline
parent with left-to-right direction</title>
(...)

        <meta name="flags" content="">

        <meta name="assert" content="When the nearest (closest within
containment hierarchy) positioned ancestor of an absolutely
positioned element is an inline-level element with left-to-right
direction, then the bounding box that serves as containing block
for such absolutely positioned element are the padding boxes of
the first and the last inline boxes generated for such
inline-level element.">

Maybe the proposed title and assert text could be furthermore improved.

3-
In the test, I would renamed #test as #containing-block. Although it
does not perfectly reflect the accurate details of the test, it is more
useful than #test and less cumbersome than
#inline-rel-pos-with-padding-establishing-containing-block .

4-
In the test, I would replaced the "Filler text" accordingly with "First
inline box" and "Last inline box".
Note that #first-box and #last-box create more than 1 line box as it is
split across 2 lines. In which case: "if the inline element is split
across multiple lines, the containing block [geometry] is
undefined.". So, the test really must be careful with that.

5-
<p>Test passes if there is no red visible on the page.</p>
could be replaced with
<p>Test passes if there is <strong>no red</strong.</p>

6- I see other small modifications, possible comments to add inside the
test. eg. .top-left and  .bottom-right would be replaced with
#overlapping-green-TL and #overlapping-green-BR. The identifier
"control" or "reference" are best used when its identifier's counterpart
is "test".

7- I have checked my modifications and most of these could be reused for
creating similar test cases, eg where the containing block is absolutely
positioned.

All of these 7 modifications can be seen in:

http://www.gtalbot.org/BrowserBugsSection/css21testsuite/containing-block-017-GT.html

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Friday, 9 March 2012 21:32:00 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 9 March 2012 21:32:07 GMT