W3C home > Mailing lists > Public > public-css-testsuite@w3.org > August 2012

[RC6] 27 margin-right-* tests not testing what they were intended to test

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Sat, 18 Aug 2012 19:55:27 -0400
Message-ID: <e3b65924d0582f11726ed568bb19f87f.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Arron Eicholz" <Arron.Eicholz@microsoft.com>
Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>
Arron,

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-004.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-005.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-006.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-016.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-017.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-018.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-028.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-029.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-030.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-040.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-041.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-042.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-052.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-053.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-054.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-064.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-065.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-066.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-076.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-077.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-078.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-088.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-089.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-090.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-109.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-110.htm

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-111.htm


While working on the src of these tests, I noticed that the [+/-]0
margin-right is set on the parent-container div and not on the
child-inner div. This makes a significant difference: these tests can
not fail. These tests are not really testing what they were intended to
test.

What is correct is a test like
http://test.csswg.org/suites/css2.1/20110323/html4/margin-right-112.htm
: where the testing of margin-right is set onto the inner div.

I had to reset my local copy of the repository; I merely copied what was
already in the centralized repository.

I will fix those 27 tests, hopefully in a way that can reuse an already
created reftest. I have been (and will be again) trying to reuse
http://test.csswg.org/source/approved/css2.1/src/margin-padding-clear/margin-left-004-ref.xht
as a reftest for all those 27 tests. Otherwise, I will create a new one.

Retrospectively speaking, I think we may have all missed those 27 tests
before (while reviewing tests; and maybe others) because we are not
trained, experienced rtl observers or familiar with rtl coding, design,
etc.

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Saturday, 18 August 2012 23:55:53 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Saturday, 18 August 2012 23:56:01 GMT