W3C home > Mailing lists > Public > public-css-testsuite@w3.org > August 2012

Re: [css3-conditional] Submitted a few TCs: at-supports-019, at-supports-022 and at-supports-027

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Fri, 3 Aug 2012 15:43:51 -0400
Message-ID: <572a6bddb4c8fb78d36fd54ca8c75a03.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Florian Rivoal" <florianr@opera.com>
Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>

Le Jeu 2 août 2012 8:22, Florian Rivoal a écrit :
> Hi,
>
> I've submitted a few TCs for @supports in
> contributors/opera/submitted/css3-conditional/
>

http://test.csswg.org/source/contributors/opera/submitted/css3-conditional/



> This is the first time I submit TCs, so I am sure I did it wrong, but
> hopefully not too much.


Florian,


I have checked a few tests and have some questions.

http://test.csswg.org/source/contributors/opera/submitted/css3-conditional/at-supports-019.html

line 11: <style>
			div {
				height:100px;
				width:100px;
			}
			@supports (margin: ) {
				div { background-color:red; }
			}
line 19:		div { background-color:green; }
		</style>


Let's assume that a particular user agent does not parse the @support
rule in this test as invalid. Let's assume here that such user agent
honors such @supports rule. Since the rule at line 19 appears after the
@supports rule, it will redefine the background-color. So, the test will
not be able to corner faulty user agents here.

"
Finally, sort by order specified: if two declarations have the same
weight, origin and specificity, the latter specified wins.
"
http://www.w3.org/TR/CSS21/cascade.html#cascading-order

"
Order of appearance. The last declaration wins.
"
http://www.w3.org/TR/css3-cascade/#cascading

Proposal
--------

line 11: <style>
			div {
                                background-color:red;
/* You want the test to identify user agents which have
no support for @supports */
				height:100px;
				width:100px;
			}
			@supports (margin: 4px) {
				div { background-color:green; }
			}


			@supports (margin: ) {
				div { background-color:red; }
			}
		</style>


---------------------

http://test.csswg.org/source/contributors/opera/submitted/css3-conditional/at-supports-022.html

		<style>
			div {
				height:100px;
				width:100px;
			}
			@supports [margin: 0] {
				div { background-color:red; }
			}
			div { background-color:green; }
		</style>

Same thing here. If squared brackets is incorrectly honored when parsing
the @supports rule, then it will not make a difference since
background-color is redefined again in the last rule. So, the test - it
seems to me - will not identify faulty, incorrect implementations.

Proposal
--------

		<style>
			div {
                                background-color:red;
				height:100px;
				width:100px;
			}

			@supports (margin: 0) {
				div { background-color:green; }
			}

			@supports [margin: 9px] {
				div { background-color:red; }
			}
		</style>


---------------------

http://test.csswg.org/source/contributors/opera/submitted/css3-conditional/at-supports-027.html

		<style>
			div {
				background-color:green;
				height:100px;
				width:100px;
			}
			@supports (margin: 0)
		</style>

This test can *_never_* fail. There is no possibility that red can be
displayed. As coded, IE4 will pass this test.


I will examine other tests...

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Friday, 3 August 2012 19:44:22 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 3 August 2012 19:44:28 GMT