W3C home > Mailing lists > Public > public-css-testsuite@w3.org > August 2012

Re: [css3-conditional] Submitted a few TCs

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Thu, 2 Aug 2012 11:16:10 -0400
Message-ID: <262cf067dc4e1e40cf8c9cfbe941381d.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Florian Rivoal" <florianr@opera.com>
Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>

Le Jeu 2 août 2012 8:22, Florian Rivoal a écrit :
> Hi,
>
> I've submitted a few TCs for @supports in
> contributors/opera/submitted/css3-conditional/
>

http://test.csswg.org/source/contributors/opera/submitted/css3-conditional/



> This is the first time I submit TCs, so I am sure I did it wrong, but
> hopefully not too much.
>


Florian,

I have checked quickly a few of them. Those are actually pretty good
ones. Although ...

1- The title should start with "CSS Test:"
http://wiki.csswg.org/test/format#title-element
{
For specifications other than CSS 2.1, you can include the module name
somewhere before the colon, like “CSS Selectors Test:” or “CSS Test
(Selectors):”.
}

So here,

<title>CSS Test (Conditional Rules): ...</title>

2-
<p>There should be a green square below and no red.</p>

a) The "below" word is unneeded. (I would say the same for "after",
"after this sentence", after this line", "afterwards", "following",
"next".) You want the pass/fail condition sentence to be as short and
meaningful as possible.
b) Because several tests have used borders to create a shape, then
several tests are now upgraded to be distinctively stating "hollow
square" and "filled square".
c) I proposed to embolden the most important words of a pass/fail
conditions sentence to help testers (eye scannability, skimmability of
text to read) reading sentences. So, here, I'd say the most important
words describing the pass/fail conditions sentence would be "no red".

Example given:
http://test.csswg.org/source/approved/css2.1/src/reference/ref-filled-green-100px-square.xht
is being reused for several dozens of tests.

3- Listing properties in rules in alphabetical order is preferred but
optional.
http://wiki.csswg.org/test/css2.1/review-checklist#nitpicky

4-
http://test.csswg.org/source/contributors/opera/submitted/css3-conditional/at_supports_001-ref.html
should have / include
<title>CSS Reftest Reference</title>
http://wiki.csswg.org/test/reftest#the-reftest-reference-file

regards , Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Thursday, 2 August 2012 15:16:44 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 2 August 2012 15:16:50 GMT