W3C home > Mailing lists > Public > public-css-testsuite@w3.org > September 2011

RE: [CSS3-mediaqueries]: Invalid test cases in test suite

From: Arron Eicholz <Arron.Eicholz@microsoft.com>
Date: Mon, 26 Sep 2011 21:23:42 +0000
To: "L. David Baron" <dbaron@dbaron.org>
CC: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
Message-ID: <07349ECFC3608F48BC3B10459913E70B148D357F@TK5EX14MBXC294.redmond.corp.microsoft.com>
On Monday, September 26, 2011 2:17 PM L. David Baron wrote:
> On Monday 2011-09-26 20:52 +0000, Arron Eicholz wrote:
> > features = [ "resolution", "min-resolution", "max-resolution" ];
> > expression_should_not_be_parseable(feature + ": 0dpi");
> >
> > The test for resolution should be parseable. According to the spec
> > (section 5) the only information about resolution is that it takes a
> > positive number. Unfortunately we defined 0 to be both positive and
> > negative. Thus this case should be parseable. Granted I do think that
> > 0dpi is silly it should be parseable or we should maybe change the
> > spec to say that resolution must a value of 1 or more.
> 
> It already says that, though perhaps it should be clearer.  It says:
> 
>   # The <ratio> value is a positive (not zero or negative) <integer>
>   # followed by optional whitespace, followed by a solidus (‘/’),
>   # followed by optional whitespace, followed by a positive
>   # <integer>.
>   #
>   # The <resolution> value is a positive <number> immediately
>   # followed by a unit identifier (‘dpi’ or ‘dpcm’).
> 
> Perhaps the (not zero or negative) should be repeated the second time the
> term "positive" is used.

I would prefer if it was a bit more specific here. I vote that we change the text to (not zero or negative).

> 
> So I believe this test is correct.

I think if we name the simple text change then I am fine with you leaving this case as is.

--
Thanks,
Arron Eicholz



Received on Monday, 26 September 2011 21:24:21 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 26 September 2011 21:24:26 GMT