W3C home > Mailing lists > Public > public-css-testsuite@w3.org > June 2011

[RC6] many max-height-* testcases can not fail; incorrect or invalid max-height-* testcases

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Tue, 21 Jun 2011 15:30:35 -0700
Message-ID: <d9806dc950a005b58917b7e742c08347.squirrel@cp3.shieldhost.com>
To: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>
Cc: "Arron Eicholz" <arron.eicholz@microsoft.com>
Hello Arron,

As coded and as worded, many max-height-* testcases can not fail.

E.g.:

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-003.htm (RC6)

http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-003.htm

says "Test passes if there is a line below."

with the following code:

div
            {
                background: black;
                max-height: 1px;
                height: 2px;
            }


If max-height is not honored or is ignored, then a 2px line is going to
be displayed. So, a normal tester (using a buggy browser or a browser
that does not support max-height) would reasonably conclude that the
test is passed.

Same thing with

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-014.htm (RC6)

http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-014.htm
using 1pt and 2pt with 1.33333px difference rounded down to 1px.



Other examples:

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-017.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-017.htm
and
http://test.csswg.org/suites/css2.1/20110323/html4/max-height-018.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-017.htm

The difference between a pass and fail is 1pt which is normally rounded
down to 1px.

Proposed solution:
#div2's height should be much more than 73pt to make the test easy to
check. It should be, say, 144pt so that a failure is very quickly and
very easily noticeable.


Other examples:

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-025.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-025.htm

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-036.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-036.htm

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-058.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-058.htm

------------

max-height-* testcases not testing what they were originally aiming at
testing:


http://test.csswg.org/suites/css2.1/20110323/html4/max-height-047.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-047.htm

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-069.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-069.htm

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-080.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-080.htm

as worded and as coded, those testcases can NOT fail. They are not
testing what they were originally aiming at testing if and when height
is set to the same value as the max-height property. So a browser which
does not support/does not implement max-height will pass those testcases
anyway.

------------

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-094.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-094.htm


http://test.csswg.org/suites/css2.1/20110323/html4/max-height-095.htm (RC6)
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-095.htm


101% of 1in may be resolved as 96px anyway (at least in some browsers
rounding down fractional pixel for height/width); so the testcase is not
good. Because of possible rounding fractional issues, it may end up NOT
testing and checking what it was originally intending to test.

Proposed solution:
#div2's height could be set to 200%; or it's max-height could be set to
50%.

------------

Invalid max-height testcases:

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-applies-to-004.htm
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-applies-to-004.htm

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-applies-to-007.htm
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-applies-to-007.htm

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-applies-to-013.htm
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-applies-to-013.htm

http://test.csswg.org/suites/css2.1/20110323/html4/max-height-applies-to-014.htm
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/max-height-applies-to-014.htm

-------------

Unfortunately, there are corrections, improvements to make in _many_
max-height-*, max-width-*, min-height-*, min-width-* testcases.


regards, Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite contributors:
http://test.csswg.org/source/contributors/
Received on Tuesday, 21 June 2011 22:31:07 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Tuesday, 21 June 2011 22:31:16 GMT