Re: [CSS3]line-break-auto-001.xht

(2011/03/29 15:57), fantasai wrote:
> On 03/16/2011 03:32 AM, taka oshiyama wrote:
>> Hello
>> Attached please find a new testcase for your review.
>> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-auto-001.xht 
>>
>> http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-auto-001-ref.xht 
>>
>>
>> Please let me know your comments/suggestions if any.
>
> Since the spec has a "recommended" part and a "suggested" ("may"), you
> should split this test accordingly into two files, one flagged with
> 'should' and the other flagged with 'may'.
Yes, I split to two files for each value, and wrote 'should' or 'may' 
into the flag one by one.
>
> Also, the test overall is in English, so the lang attribute should be
> applied to the test content, not the document as a whole.
Yes, corrected to 'EN'.
>
> Also, since the tests are very sensitive to the advance width, the IPA
> font will have to be required, not just suggested if the glyphs are
> not otherwise visible.
Yes, corrected the instruction as "* You need Japanese fonts to see all 
font glyphs correctly.".
>
>
> Otherwise this looks pretty good.
>
> ~fantasai
>
Hello fantasai
Thanks for your useful comments.
I updated as below accordingly.
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-auto-001.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-auto-002.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-loose-001.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-loose-002.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-normal-001.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-normal-002.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-strict-001.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/line-break-strict-002.xht

http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-auto-001-ref.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-auto-002-ref.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-loose-001-ref.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-loose-002-ref.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-normal-001-ref.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-normal-002-ref.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-strict-001-ref.xht
http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/reftest/line-break-strict-002-ref.xht

Please give me any further comments/questions if any.

regards,

-- 


押山 隆 taka oshiyama
oshiyama@est.co.jp (or takaoshiyama@gmail.com)
mobile: 080-4148-7654
イースト株式会社
〒151-0053 渋谷区代々木2-22-8