W3C home > Mailing lists > Public > public-css-testsuite@w3.org > October 2010

Re: Proposed improvements to c414-flt-ln-002

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Thu, 7 Oct 2010 12:52:26 -0700
Message-ID: <76fbf90a95b88b9d7d89799355b14600.squirrel@cp3.shieldhost.com>
To: "Ă˜yvind Stenhaug" <oyvinds@opera.com>
Cc: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>, "Geoffrey Sneddon" <gsneddon@opera.com>

> On Wed, 06 Oct 2010 22:15:13 +0200, GĂ©rard Talbot
> <css21testsuite@gtalbot.org> wrote:
>
>> Ă˜yvind, you wrote in
>>
>> http://wiki.csswg.org/test/css2.1/issues#tests-that-need-usability-improvements
>
> Actually,
> http://wiki.csswg.org/test/css2.1/issues#miscellaneous-incorrect-tests
>
>> that the testcase is too complex. What about
>> http://www.gtalbot.org/BrowserBugsSection/css21testsuite/c414-flt-ln-002-draft.htm
>> then?
>
> It looks better, but still probably too complicated to accurately judge
> without knowledge of how floats work (and even of the particular markup
> of
> this test). It's not obvious what counts as "enough horizontal room".


I understand what you're saying. I'll think about this.


> If the big green box is aligned to the line below the small green box,
> and
> the small green box has a bunch of "filler text" to its left that fills
> a
> bigger space than the green box would need, does that mean it's a fail
> or
> not?


No, it does not (and should not) mean that it is a fail in such case.


> Actually, this depends on where the small green box is located. If
> moving the large box up would cause the small box to be pushed to the
> next
> line when the filler text is pushed to the right, it's not a fail.
> Otherwise it is.
>
> I was thinking something like this, and with a separate copy for a case
> where the float has to be moved down (I changed a color to blue since
> the
> word "teal" is kind of obscure):
>
> @@ -2 +1,0 @@
> -
> @@ -13,2 +12,2 @@
> -  <meta name="flags" content="interact">
> -  <meta name="assert" content="The top edge of the margin box of a
> floated box is aligned with the top of the current line box. If there is
> not enough horizontal room for the margin box of such floated box, then
> it
> is shifted downward into a next line box until either it fits; in such
> case, its top edge must again be aligned with the top of such next line
> box.">
> +  <meta name="flags" content="ahem">
> +  <meta name="assert" content="The top edge of the margin box of a
> floated box is aligned with the top of the current line box.">


So, it is no longer an interactive testcase.


> @@ -20 +19 @@
> -  font: 1.25em/1.2 serif;
> +  font: 1.25em/1.0 ahem;
> @@ -22,0 +22 @@
> +  width: 30em;
> @@ -34,2 +34,2 @@
> -  background-color: teal;
> -  color: white;
> +  color: blue;
> +  background-color: blue;
> @@ -40 +40 @@
> -  border: teal solid 4px;
> +  border: blue solid 4px;
> @@ -45,0 +46 @@
> +  color: green;
> @@ -47 +47,0 @@
> -  color: white;
> @@ -61,3 +61 @@
> -  <p>The top of the big triple-letter coloured boxes should be flush
> with
> the top of the small single-letter coloured boxes of the same color. If
> there is not enough horizontal room for the big box to fit on the small
> box's line on its left side, then the big box should appear on the
> leftmost part of next line of where is the small box.</p>
> -
> -  <p>You can resize the window to change respective position of boxes
> and
> you can increase/decrease the font size to verify.</p>
> +  <p>The top edges of the two blue boxes should be flush with each
> other,
> and the top edges of the two green boxes should be flush with each
> other.</p>
> @@ -65,2 +63 @@
> -  <div>filler text filler text filler text filler text filler text
> filler
> text
> -   filler text <span class="a">A</span>
> +  <div>filler text <span class="a">A</span>
> @@ -68 +64,0 @@
> -   filler text filler text filler text filler text filler text filler
> text
> @@ -70 +65,0 @@
> -   filler text filler text filler text filler text filler text filler
> text
> @@ -74,6 +68,0 @@
> -   filler text filler text filler text filler text filler text filler
> text
> -   filler text filler text filler text filler text filler text filler
> text
> -   filler text filler text filler text filler text filler text filler
> text
> -   filler text filler text filler text filler text filler text filler
> text
> -   filler text filler text filler text filler text filler text filler
> text
> -   filler text filler text filler text filler text filler text filler
> text


I created and uploaded your testcase:

http://www.gtalbot.org/BrowserBugsSection/css21testsuite/c414-flt-ln-002-draft-%C3%98yvind.htm

Because it is now entirely static and semi-rigid (enclosing div width is
30em), then it loses a lot of the aspects (resizing dimensions, resizing
of text size impacting on content dimensions) of the original testcase.
That is what I was trying to preserve.
There are already quite a few testcases on vertical alignment of floats
in static testcase in the test suite.

It is not clear in my mind what ahem font does more or does better than
what a normal serif font was doing in my version or could do when used
in your version.

regards, Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 test suite (RC2; October 1st 2010):
http://test.csswg.org/suites/css2.1/20101001/html4/toc.html

CSS 2.1 test suite contributors:
http://test.csswg.org/source/contributors/
Received on Thursday, 7 October 2010 19:53:03 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 7 October 2010 19:53:10 GMT