W3C home > Mailing lists > Public > public-css-testsuite@w3.org > October 2010

Re: More test feedback

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Wed, 6 Oct 2010 12:18:02 -0700
Message-ID: <7320e1721ae1c5f6fdcce3d07c977c3d.squirrel@cp3.shieldhost.com>
To: "Simon Fraser" <smfr@me.com>
Cc: "Public CSS 2.1 test suite mailing list" <public-css-testsuite@w3.org>
> block-in-inline-004

I wish everyone would always provide the full url of testcases. This
saves time and make checking testcases easier, quicker. No pasting of
base url needed, no opening of a new tab required. Having the base url
also makes certain which version of testsuite.

> Ambiguous: the text goes green when you hover to the right of the text
too.

http://test.csswg.org/suites/css2.1/20101001/html4/block-in-inline-004.htm

The pass condition clearly implies hovering over the text. Hovering over
to the right of the middle sentence is an incidental consequence of the
testcase and is not necessarly part of the testcase.

> border-bottom-applies-to-010
> border-bottom-color-applies-to-010
> border-bottom-style-applies-to-010
> border-bottom-width-applies-to-010
> border-top-applies-to-010
> border-top-color-applies-to-010
> border-top-style-applies-to-010
> border-top-width-applies-to-010
> margin-bottom-applies-to-010
> and probably more.
> These tests are vague about whether the position of the bullet
matters.

I do not believe that the vertical position of the bullet with regards
to to the borders should be explicitly defined for those testcases.

> They say "there is a marker bullet on the left-hand side of the line",
but in many cases the bullet is not aligned with the line.

Then the vertical alignment of the bullet with regards to line is not
part of the testcase and should not be considered part of the pass
condition.

The bullet will occupy an upper position with regards to the
border-bottom testcases while it will occupy a lower position with
regards to border-top testcases. But again, such vertical position is
not part of the test.

> border-bottom-width-012
> border-bottom-width-023
> border-bottom-width-034
> border-bottom-width-045
> border-bottom-width-056
> border-bottom-width-067
> border-bottom-width-078
> and same-numbered border-top-width tests.
> It's unclear if the line should be continuous, or whether a gap in the
middle is OK.

http://test.csswg.org/suites/css2.1/20101001/html4/border-bottom-width-012.htm

The testcase should have been made clear about this because the width of
the 2 underlining lines for each group of 3 "Filler text" has to be
compared and that is precisely part of the test.

Proposed replacement:

<span id="span1">Filler Text Filler Text Filler Text&nbsp;</span><span
id="span2">Filler Text Filler Text Filler Text</span>

so that there seems to be only 1 line and that such line should
consistently have the same thickness.



> c5518-brdr-t-001
> c5520-brdr-b-001
> It's hard to know what "directly over" means. In WebKit, there's more
space between the word and the line above in one case, but it's
unclear

http://test.csswg.org/suites/css2.1/20101001/html4/c5518-brdr-t-001.htm

>From what I can see with debugger tools (Web Inspector, DOM inspector
and DragonFly), there is a 1px difference. Webkit (Chrome 6.0.472.63)
user agent stylesheet uses a default 2px padding for cells (td); Firefox
3.6.10 and Opera 10.62 user agent stylesheet uses a default 2px padding
for cells (td).

Proposed adjustment for c5518-brdr-t-001:
td { text-align: center; padding-top: 0px;}

Also
s/occurance/occurrence/

http://test.csswg.org/suites/css2.1/20101001/html4/c5520-brdr-b-001.htm

Proposed adjustment for c5520-brdr-b-001:
td { text-align: center; padding-bottom: 0px;}

> whether this is a fail.
> content-counters-001
> content-counters-002
> content-counters-003
> Is "exactly the same" a pass?
> floats-025
> Badly worded; does "on the right" mean inside or outside?

http://test.csswg.org/suites/css2.1/20101001/html4/floats-025.htm

I agree it's confusing and not best worded.

Proposed adjustment:

<p>Test passes if the blue square is in the upper-right corner of the
black box.</p>


regards, Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 test suite (RC2; October 1st 2010):
http://test.csswg.org/suites/css2.1/20101001/html4/toc.html

CSS 2.1 test suite contributors:
http://test.csswg.org/source/contributors/
Received on Wednesday, 6 October 2010 19:18:39 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Wednesday, 6 October 2010 19:18:46 GMT