W3C home > Mailing lists > Public > public-css-testsuite@w3.org > January 2010

RE: 3 Microsoft margin collapsing tests (wrt float, clear and clearance)

From: Arron Eicholz <Arron.Eicholz@microsoft.com>
Date: Thu, 21 Jan 2010 01:44:37 +0000
To: "css21testsuite@gtalbot.org" <css21testsuite@gtalbot.org>, "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
Message-ID: <651D2A831D17C040B828D62270386CE9299FA7CB@TK5EX14MBXC132.redmond.corp.microsoft.com>
Gérard Talbot wrote on Wednesday, January 20, 2010 1:56 PM:
> 
> http://test.csswg.org/source/contributors/microsoft/submitted/Chapter_8/
> margin-collapse-018.xht
> 
> a) How come an element on which clear is set (to other than none) can have
> an effect when there is no preceding floated sibling in the test?
> 

This is a test case bug I am looking into fixing this but have been side tracked by another test case at the moment. I will be submitting an update for this case soon. I'll let you know.

> 
> -------------------------
> 
> http://test.csswg.org/source/contributors/microsoft/submitted/Chapter_8/
> margin-collapse-023.xht
> 

Another test cases bug. I have updated the test case and it should now be more logical.

Please also look at case margin-collapse-025.xht. I'm not 100% sure it is correct either. It's a different rule. I think it might just have the logic wrong again.

> --------------------
> 
> http://test.csswg.org/source/contributors/microsoft/submitted/Chapter_8/
> margin-collapse-027.xht
> 
> <meta assert says: "Top margins collapse to siblings and bottom margin do
> not collapse when own margins collapse and clearance is applied."
> 
> a) This sentence is utterly difficult to understand and seems awkwardly
> written.

Ummm... Yeah. Yuck. It is changed and maybe makes more sense. Let me know if it's still a little weird.

> 
> b) The test has an element on which clear is set but there is no float
> anywhere in the test. So, how could there be a clearance created?

Rewrote the case it now makes sense.

> c) The markup is
> 
>         <div id="div1">
>             <div id="div2">
>                 <div id="div3"></div>
>                 <div id="div4"></div>
>             </div>
>             <div id="div5"></div>
>         </div>
> 
> Again, what would be best for CSS newbies, ordinary web authors wishing to
> see/examine examples of margin collapsing for learning purposes. I suggest
> more intuitive, meaningful id semantic.
> 
>         <div id="containing-block">
>             <div id="div2">
>                 <div id="div3"></div>
>                 <div id="clear-both"></div>
>             </div>
>             <div id="ordinary-sibling"></div>
>         </div>

Love the idea. I wish I would have thought about it when we created all of our tests. Unfortunately I want to keep all of our cases consistent across the entire test suite. For now I am going to leave it as div1, div2, etc. but if I have time I might change all the tests that we have submitted.

--
Thanks,
Arron Eicholz
Received on Thursday, 21 January 2010 01:45:28 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:52:01 GMT