- From: L. David Baron <dbaron@dbaron.org>
- Date: Wed, 1 Dec 2010 19:44:47 -0800
- To: Arron Eicholz <Arron.Eicholz@microsoft.com>
- Cc: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
On Wednesday 2010-12-01 19:43 -0800, L. David Baron wrote: > On Thursday 2010-12-02 02:27 +0000, Arron Eicholz wrote: > > On Friday, October 15, 2010 5:04 PM, L. David Baron wrote: > > > These tests: > > > http://test.csswg.org/suites/css2.1/20101001/html4/line-height-014.htm > > > http://test.csswg.org/suites/css2.1/20101001/xhtml1/line-height-014.xht > > > are invalid because of rounding issues. > > > > > > They use a font-size of 16px and a line-height of 1.3333px, and assert that the > > > top of the font in the first line and the bottom of the font in the next line are > > > separated by 17px. However, since CSS does not define rounding behavior, > > > they could reasonably be separated by 18px. > > > > > > I'd recommend testing rounder values instead, or loosening the pass criteria. > > > > Fixed, changed the font value to 20px. > > While that does happen to fix it in one case (Gecko on Linux with my > default font size), I don't think it's sufficient since the > line-height is still 1.3333px. Also, when the test does pass, the pass condition is rather unclear since the boxes are touching (and therefore look like a single box, not two). -David -- L. David Baron http://dbaron.org/ Mozilla Corporation http://www.mozilla.com/
Received on Thursday, 2 December 2010 03:45:18 UTC