W3C home > Mailing lists > Public > public-css-testsuite@w3.org > December 2010

RE: Proposed adjustment for first 26 at-charset testcases (was Re: at-charset-013)

From: Arron Eicholz <Arron.Eicholz@microsoft.com>
Date: Thu, 2 Dec 2010 02:27:35 +0000
To: "css21testsuite@gtalbot.org" <css21testsuite@gtalbot.org>, Chris Lilley <chris@w3.org>
CC: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
Message-ID: <07349ECFC3608F48BC3B10459913E70B102F9312@TK5EX14MBXC140.redmond.corp.microsoft.com>
On Thursday, November 25, 2010 11:53 AM Gérard Talbot wrote:
> http://test.csswg.org/suites/css2.1/20101027/html4/at-charset-013.htm
> 
> Le Mer 24 novembre 2010 9:24, Chris Lilley a écrit :
> > Hello public-css-testsuite,
> > In the test Test at-charset-013, the pass criteria is "Test passes if
> the "Filler Text" below is green."
> > But there are then two lines, both of them have the same text Filler
> > Text Filler Text
> 
> Hello Chris,
> 
> I fully and entirely agree with your comments on at-charset-*.
> 
> There should be 2 distinct, identifiable and distinctive text
> *_samples_* in that testcase and the pass criteria should refer to those
> 2 sentences (or lines of text) being green. The plural form should be used,
> obviously (this is exactly the type of comments that my neighbour or bus
> driver would give). And this is true for all testcases starting (in the range)
> from at-charset-001 to at-charset-030.
> 
> 
> > In Firefox Mnefield 4.0b8pre I see the top line in red and the bottom
> line in green. According to the pass criteria, this is a pass because it
> > is in green below. But its also in red below.
> > If the intent is that both lines are green, this should be said
> > explicitly.
> > (While I was typing this we resolved on the CSS WG call that yes, both
> lines should be green)
> 
> Then that should be clear for an ordinary person under normal circumstances
> trying, testing all these at-charset testcases.
> 
> I have reported the issue at
> http://wiki.csswg.org/test/css2.1/issues#tests-that-need-usability-
> improvements
> 
> Proposed adjustment for the first 26 at-charset testcases
> =========================================================
> 
>     <p>Test passes if the 2 "Text sample" are green.</p>
> 
>     <div class="...">Text sample 1</div>
>     <div id="div2">Text sample 2</div>
> 

Fixed all the issues the same way with a new pass condition.

--
Thanks,
Arron Eicholz
Received on Thursday, 2 December 2010 02:28:42 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 2 December 2010 02:48:08 GMT