W3C home > Mailing lists > Public > public-css-testsuite@w3.org > October 2008

Re: CSS Namespaces Module Test Suite

From: fantasai <fantasai.lists@inkedblade.net>
Date: Mon, 13 Oct 2008 04:53:16 -0700
Message-ID: <48F336AC.8020103@inkedblade.net>
To: Anne van Kesteren <annevk@opera.com>
CC: public-css-testsuite@w3.org

Anne van Kesteren wrote:
> 
> Hi,
> 
> I created a set of tests for the CSS Namespaces Module and reported bugs 
> on Opera and Firefox for the failures they each had. Unless someone 
> beats me to it I will probably take a look at Safari next week when I 
> have access to my MacBook again.
> 
> I checked the tests into dev.w3.org:
> 
>   http://dev.w3.org/CSS/css3-namespace-test-suite/

Thanks, Anne. Here are my comments:

s/line/sentence/g; since in some cases only the sentence has a
background and in some cases the background stretches across the
screen. We don't want to make the tester think that this difference
is significant.

Also, you need to add
   - tests that introduce various whitespace and comment patterns
   - tests for parsing failures within the @namespace rule (to make
     sure the failure is detected, causes the rule to be ignored, and
     doesn't affect anything outside the scope of the "ignore" behavior
     for @rules).
   - tests for @namespace followed by an invalid @rule (both invalid
     rules with known @keywords and rules with unknown @keywords)

http://dev.w3.org/CSS/css3-namespace-test-suite/src/prefix-001.xml

   - Swap the order of the namespace declarations so that "x" wins
     in case the UA is mapping both declarations to the same prefix.
     (In this case neither background color will appear. Or you could
     add a test
       { background: red }
     rule to make it red in such a case.)
   - Add a rule
       FOO|test { background: red; }
     which tests an unbound prefix with the same case-insensitive
     mapping as the correct bound prefix.

http://dev.w3.org/CSS/css3-namespace-test-suite/src/prefix-002.xml
http://dev.w3.org/CSS/css3-namespace-test-suite/src/prefix-003.xml

   - These two have the same title. Please add something to the title
     to distinguish the two tests for when they are indexed in a TOC.

http://dev.w3.org/CSS/css3-namespace-test-suite/src/prefix-004.xml

   r+

http://dev.w3.org/CSS/css3-namespace-test-suite/src/prefix-005.xml

   - Put a rel="author" line for bz instead of a comment.
   - I don't think "empty string default namespace" is an appropriate
     title here. It's also a duplicate of the previous title. Please
     choose something appropriately unique and descriptive.


http://dev.w3.org/CSS/css3-namespace-test-suite/src/scope-001.xml

   - I would title this 'scope <style>' to be more precise

http://dev.w3.org/CSS/css3-namespace-test-suite/src/scope-002.xml

   - Shift the test { background: lime } up into a separate <style>
   - Add an @namespace w declaration to the <style> with the @import
     and a
       w|test { background:red}
     rule to the scope.css style sheet
   - Add another @import with another external style sheet and add
     y and z declarations/selectors to test crossing sibling @imports.

http://dev.w3.org/CSS/css3-namespace-test-suite/src/syntax-001.xml

   - This should perhaps be @namespace "string".
   - You also should have corresponding tests with 'string' and url().
     For url() syntax you need to test all three of double-quoted,
     single-quoted, and unquoted url() syntax.

http://dev.w3.org/CSS/css3-namespace-test-suite/src/syntax-002.xml

   - Add a backslash before the 'p' and the 'N' in @NAmespace.
   - Unicode-escape the A with six digits plus a space.

http://dev.w3.org/CSS/css3-namespace-test-suite/src/syntax-003.xml

   - The title should mention that this is a default namespace
     declaration.
   - Add corresponding tests with 'string' and "string".

http://dev.w3.org/CSS/css3-namespace-test-suite/src/syntax-004.xml

   r+

http://dev.w3.org/CSS/css3-namespace-test-suite/src/syntax-005.xml
http://dev.w3.org/CSS/css3-namespace-test-suite/src/syntax-006.xml

   - Apart from the escaped r, it seems -006 is merely a more complex
     form of -005, i.e. aside from the escape -005's test is a subset
     of -006. Was that the intent, or am I missing something here?
     Because if so, I would suggest removing -005, it doesn't seem
     necessary.

http://dev.w3.org/CSS/css3-namespace-test-suite/src/syntax-007.xml

   - This test is effectively the same as one with the @charset rule
     replaced by @foo;, because @charset is not valid there. You need
     to rewrite this test to use an external style sheet and place
     the @charset rule at the start of the style sheet.

http://dev.w3.org/CSS/css3-namespace-test-suite/src/syntax-008.xml

   - You should also test prefixes that start with an escaped
     character that is not otherwise allowed in an identifier.
   - You need to test escapes in both the @namespace declaration
     and in the selector (but the escaping should not match).
   - I'd mention escaping in the title since that's mainly what's
     being tested here.

~fantasai
Received on Monday, 13 October 2008 11:53:58 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:51:57 GMT