Re: CSS2.1 i18n and bidi tests for review

On Sat, 19 Jul 2008 11:38:43 +0200, fantasai  
<fantasai.lists@inkedblade.net> wrote:

> Eira Monstad wrote:
>>  On Fri, 18 Jul 2008 11:21:04 +0200, fantasai  
>> <fantasai.lists@inkedblade.net> wrote:
>>
>>> Eira Monstad wrote:
>>>>  Cheers,
>>>>  I've been working on some bidi related tests for the 2.1 testsuite,  
>>>> as well as converting a few of Richard Ishida's tests for language  
>>>> dependent styling to match the testsuite template. The tests are  
>>>> ready for review at http://people.opera.com/eiram/test/css21/review/
>>>
>>> http://people.opera.com/eiram/test/css21/review/bidi-direction-001.xht
>>> http://people.opera.com/eiram/test/css21/review/bidi-direction-002.xht
>>>
>>> So.. there seem to be two main assertions here:
>>>    - That 'direction' inherits (and affects the paragraph text as  
>>> defined).
>>>    - That 'direction' affects alignment.
>>> Both tests test both, and I'm having a hard time figuring out what is
>>> functionally different between the two.
>>  001 tests that body direction is inherited by element when direction  
>> is not specified on the paragraph.
>>  002 tests that body direction is overridden correctly by direction  
>> property on the paragraph.
>>  I have updated the assert in 002 to make the difference clearer.
>
> They both test both. It's just that in 001 the "override" test is called
> the control, and its default alignment is not tested.

Ok, fair enough. Pick one and leave the other :)


-- 
Eira Monstad
CoreQA

Furthermore, it is my opinion that BTS2 must be destroyed

Received on Tuesday, 26 August 2008 05:50:41 UTC