W3C home > Mailing lists > Public > public-css-testsuite@w3.org > August 2007

Re: Some proposed tests

From: fantasai <fantasai.lists@inkedblade.net>
Date: Mon, 20 Aug 2007 15:54:11 -0400
Message-ID: <46C9F163.50607@inkedblade.net>
To: "Grant, Melinda" <melinda.grant@hp.com>
CC: public-css-testsuite@w3.org

Grant, Melinda wrote:
> Attached are some proposed tests ready for review.
>  
> For CSS 2.1:
>     page-left-right-000.xht

- The CSS indentation on this page is weird. Maybe use spaces instead of tabs?
   It doesn't line up very well with e.g. 8 spaces per tab.
- I'd add
     div {
        color: blue;
        text-align: center;
     }
   and use 60% instead of 50% in the margins to make the alignment clearer
   to the tester.

 >     page-cb-000.xht

- Please remove all declarations in the @page rule (aside from the "margin: 1in"
   declaration. They will be added by the build scripts.
- The blue border will not show up at the bottom because 'height: 100%' is
   exclusive of borders. You could assign the borders to the left and right
   sides only and require that they extend the full height of the aqua box.
   Use a much thicker border, though.
- The title should mention @page margins, as we probably want to add a similar
   test that doesn't depend on @page margins.


 >     page-breaki-000.xht

- The title should be more specific, e.g. "page-break-inside: avoid on lists"
- The assertion should be more assertive:
     "page-break-inside: avoid prevents breaking inside a list"
- Don't use green for the box, green is used to indicate a pass condition.
   In this case you want to use gray, for descriptive lines.
- The test works on a somewhat limited range of page sizes. One way to
   increase the range of page sizes would be to use two boxes that add up
   to 100% height plus some negative margins, like this:

   body {
      font-size: 10pt;
      line-height: 1;
   }

   .filler {
      height: 50%;
      border: 2pt medium gray;
   }
   .no2 {
      margin-top: -38pt;
   }

   <div class="filler">...</div>
   <div class="filler no2"></div>
   <ol> ... </ol>

   This ensures that there is exactly 30pt of space at the bottom of the page,
   no more, no less, no matter what size page we have (as long as it's bigger
   than 38pt), and the list will therefore always fall on the page break.
   You can then shorten the list to the first eight items so that it will fit
   entirely on smaller sheets as well.

>     page-first-000.xht

- Please remove all declarations in the @page rule (aside from the "margin: 1in"
   declaration. They will be added by the build scripts.
- This is not a valid CSS2.1 test because the two pages have different page area
   widths, and support for that is not required. Having uneven margins and swapping
   which side is wider would be a valid test.
- Specify the yellow color on html, not on body.
- "This text must have a one inch margin" is not clear. Maybe "the yellow box on
    this page must have a one inch margin around it"?

> For CSS3 Paged Media:
>     page-pseudo-000.xht

- Please remove all declarations in the @page rule (aside from the "margin: 1in"
   declaration. They will be added by the build scripts.
- Use at least 50% for the margins, preferably 60%.
- Use pts instead of px.
- I suggest clarifying the descriptions as
     "This text must be on the right side of the page, which must have an orange
      border entirely on the right half of the page."
    and
     "This text must be on the left side of a new (second) page, which must have
      a blue border entirely on the left half of the page."
- Alternatively you could change this test to rely only on border color + style,
   since the CSS2.1 version above will be imported into this test suite as well.

>     page-named-000.xht

- Please remove the first @page rule.
- In the description, mention the exact text of the header so it can be picked
   out from the generated test headers. Also, remove the last sentence and append
   ", in a text size larger than this text" to the first sentence.
- Don't use red for the header. Red is only used to indicate failures. Use 'blue'.

~fantasai
Received on Monday, 20 August 2007 19:54:35 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:51:55 GMT