W3C home > Mailing lists > Public > public-css-testsuite@w3.org > August 2007

Re: problem with t040103-ident-03-c.htm?

From: Ray Kiddy <ray@ganymede.org>
Date: Thu, 2 Aug 2007 18:46:28 -0700
Message-Id: <722782E7-E3C5-47A7-BD29-6B7A35105E24@ganymede.org>
To: public-css-testsuite@w3.org

fantasai -

Your version looks good to me.

thanx - ray

On Aug 2, 2007, at 5:05 PM, fantasai wrote:

> Ray Kiddy wrote:
>> Hello -
>
> Hey Ray,
>
> Sorry it took awhile to get to this, I had my hands full with  
> getting bug
> 379349 done before the 1.9 freeze.
>
>> I was looking at one of the tests: http://www.w3.org/Style/CSS/ 
>> Test/CSS2.1/current/t040103-ident-03-c.htm
>> On my Firefox (Mac OS X, nightly build of FF 3.0a7pre from  
>> 7/20/2007), it shows up red. I added a note about this test to:
>>     https://bugzilla.mozilla.org/show_bug.cgi?id=12385.
>>     CSS idents can't start with "-"
>> Some of the FF people suggest the CSS test is wrong. In looking at  
>> the spec (http://www.w3.org/TR/CSS21/syndata.html#value-def- 
>> identifier), it looks as though a hyphen is allowed at the start  
>> of an identifier, unless the hyphen is followed by a digit. If I  
>> am understanding, then perhaps t040103-ident-03-c.htm can be as  
>> below.
>> Or am I wrong?
>
> No, you're right. :) The test needs to be fixed. Your code has a  
> couple of
> mistakes in it, though.
>
>>   .three { color: green; background: white; }
>>   .-1ident, .one { color: red; }
>>   .four { color: green; background: white; }
>>   #-1ident, .two { color: red; }
>
> I'm guessing you meant .three and .four there.
>
>>   .five { color: green; background: white; }
>>   .-\1ident, .one { color: red; }
>>   .six { color: green; background: white; }
>>   #-\1ident, .two { color: red; }
>
> The class and ID here are actually valid, because identifiers are  
> allowed
> to contain escaped anything. See the note at the end of section 4.1.3:
>   http://www.w3.org/TR/CSS21/syndata.html#characters
>
> I swapped the colors and changed the escape to represent '1'  
> instead of
> U+0001. (Hexadecimal digits can't be escaped with a backslash:  
> they'd be
> indistinguishable from Unicode escapes otherwise.)
>
> Here's the diff. Check it. If it looks good to you, I'll check it in.
>
> ~fantasai
> ? raydiff
> Index: t040103-ident-03-c.xht
> ===================================================================
> RCS file: /sources/public/CSS/CSS2.1-test-suite/cooked-tests/ 
> dbaron-20041214/t040103-ident-03-c.xht,v
> retrieving revision 1.3
> diff -u -r1.3 t040103-ident-03-c.xht
> --- t040103-ident-03-c.xht	2 Aug 2007 23:53:24 -0000	1.3
> +++ t040103-ident-03-c.xht	2 Aug 2007 23:55:36 -0000
> @@ -3,14 +3,27 @@
>   <head>
>    <title>CSS 2.1 Test Suite: Characters and Case</title>
>    <link rel="author" title="L. David Baron" href="http:// 
> dbaron.org/"/>
> +  <link rel="author" title="Ray Kiddy"  
> href="mailto:ray@ganymede.org"/>
>    <link rel="help" href="http://www.w3.org/TR/CSS21/ 
> syndata.html#characters"/>
>    <style type="text/css">
>
> -  .one { color: green; background: white; }
> -  .-ident, .one { color: red; }
> +  .one { color: red; background: white; }
> +  .-ident, .one { color: green; }
>
> -  .two { color: green; background: white; }
> -  #-ident, .two { color: red; }
> +  .two { color: red; background: white; }
> +  #-ident, .two { color: green; }
> +
> +  .three { color: green; background: white; }
> +  .-1ident, .three { color: red; }
> +
> +  .four { color: green; background: white; }
> +  #-1ident, .four { color: red; }
> +
> +  .five { color: red; background: white; }
> +  .-\31ident, .five { color: green; }
> +
> +  .six { color: red; background: white; }
> +  #-\31ident, .six { color: green; }
>
>    </style>
>   </head>
> @@ -18,6 +31,10 @@
>
>   <p class="one">This should be green.</p>
>   <p class="two">This should be green.</p>
> + <p class="three">This should be green.</p>
> + <p class="four">This should be green.</p>
> + <p class="five">This should be green.</p>
> + <p class="six">This should be green.</p>
>
>   </body>
>  </html>
Received on Friday, 3 August 2007 01:46:46 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:51:55 GMT