Re: [csswg-drafts] [css-text] Custom character replacement rules for `text-transform`

One suggestion, let's not continue using the plain `<custom-ident>`. I think it was probably a mistake to allow arbitrary identifier to be used like keyword values, for several reasons:
1. invalid value can suddenly become valid which leads to unexpected behavior change for some error cases,
2. it restricts our future extension to the property,
3. make implementation more complicated (for example, `@counter-style` requires names in a given list to be case-insensitive, which wouldn't be necessary if we don't allow overriding from the very beginning).

Maybe either require prefixing custom values with `--` or use string instead.

(I probably should update Gecko's `@counter-style` implementation so that we can get rid of these pitfalls from there as well... I guess it is doable...)

-- 
GitHub Notification of comment by upsuper
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/3132#issuecomment-424580760 using your GitHub account

Received on Wednesday, 26 September 2018 04:27:25 UTC