Re: [csswg-drafts] [css-grid] Applying 'justify-content' content distribution is in the wrong place in the overall grid sizing algo

> @javifernandez Given the above, do you agree that it's okay to move content distribution up into new steps 1.5 and 2.5 (and eliminate step 4)?

@tabatkins are you talking about the original 6 steps fantasai described ? 

1. Size the columns, making some estimates about row sizes (if needed for orthogonal flows)
2. Size the rows, using the column sizes we just calculated (if needed for orthogonal flows)
3. Size the column, using the row sizes we just calculated (skip if not needed)
4. Size the rows, using the column sizes we just calculated (skip if not needed)
5. Align the tracks
6. Lay out items into the resulting grid areas

Wouldn't be the step 5 the one that should be removed ? I don't follow why we should remove step 4, neither in the 6 original steps or in the new ones (reduced to 5 steps)

In any case, and with some caution until I had the time to implement a prototype for this change, I think those new steps 1.5 and 2.5 will produce better results and I'm for it. I'd like to know the @MatsPalmgren 's opinion about this, since he was the one creating the issue; besides, I'm curious about how and why he implemented it in the first place, because this is the Firefox's  current behavior, right ?  

-- 
GitHub Notification of comment by javifernandez
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/2557#issuecomment-390658292 using your GitHub account

Received on Monday, 21 May 2018 13:46:30 UTC