W3C home > Mailing lists > Public > public-audio@w3.org > July to September 2017

Re: review of contiguous IDL

From: Joe Berkovitz <joe@noteflight.com>
Date: Thu, 21 Sep 2017 09:03:50 -0400
Message-ID: <CA+ojG-bh7VBRVV8HjFxMMfZT45vAwVMLtMnsAhxBD+Uk64durg@mail.gmail.com>
To: "Jerry Smith (WPT)" <jdsmith@microsoft.com>
Cc: Raymond Toy <rtoy@google.com>, Audio Working Group <public-audio@w3.org>
I've fixed the broken links in
https://github.com/WebAudio/web-audio-api/pull/1340

.            .       .    .  . ...Joe

Joe Berkovitz
Founder
Noteflight LLC

49R Day Street
Somerville MA 02144
USA

"Bring music to life"
www.noteflight.com

On Wed, Sep 20, 2017 at 7:27 PM, Jerry Smith (WPT) <jdsmith@microsoft.com>
wrote:

> It appears that validator re-runs when opening the results link below…
> Still useful!
>
>
>
> *From:* Raymond Toy [mailto:rtoy@google.com]
> *Sent:* Wednesday, September 20, 2017 4:15 PM
>
> *To:* Joe Berkovitz <joe@noteflight.com>
> *Cc:* Audio Working Group <public-audio@w3.org>
> *Subject:* Re: review of contiguous IDL
>
>
>
> Validator results:  https://validator.w3.org/checklink?uri=http%3A%
> 2F%2Fwebaudio.github.io%2Fweb-audio-api%2F&hide_type=all&
> depth=&check=Check#results1
>
>
>
> (Hope that works.  This is really helpful.)
>
>
>
> I think I can fix the broken internal links pretty quickly.
>
>
>
> On Wed, Sep 20, 2017 at 4:12 PM, Raymond Toy <rtoy@google.com> wrote:
>
>
>
>
>
> On Wed, Sep 20, 2017 at 1:38 PM, Joe Berkovitz <joe@noteflight.com> wrote:
>
> Hi Ray,
>
>
>
> You probably already explained this, but all of the autogenerated
> #widl-xxx anchors for attributes and methods are now in the form #dom-xxx.
> These are not caught as ReSpec errors. They amount to many (perhaps 100%?)
> of the now-broken internal links in the document.
>
>
>
> Actually, I didn't explain it, except that many links are broken.
>
>
>
> In fact, I think it's also incorrect to use #dom-xxx. I think the right
> thing is <a data-link-for="section-or-idl-name">link</a>.
>
>
>
> Do we need there another V1 blocker issue to go back and fix these?
>
>
>
> Yeah, we probably should. I started to go through some now, but decided to
> wait for the other blockers.  It's a gigantic pain to do, but we need to
> find them all.
>
>
>
> I thought Paul had added some stuff to list all of the broken links.  That
> that got deleted or isn't working any more?
>
>
>
> I'm running validator.w3.org now to see if that will help us find all the
> broken links....
>
>
> .            .       .    .  . ...Joe
>
> Joe Berkovitz
> Founder
> Noteflight LLC
>
> 49R Day Street
> <https://maps.google.com/?q=49R+Day+Street+Somerville+MA+02144+USA&entry=gmail&source=g>
> Somerville MA 02144
> <https://maps.google.com/?q=49R+Day+Street+Somerville+MA+02144+USA&entry=gmail&source=g>
> USA
> <https://maps.google.com/?q=49R+Day+Street+Somerville+MA+02144+USA&entry=gmail&source=g>
>
> "Bring music to life"
> www.noteflight.com
>
>
>
> On Wed, Sep 20, 2017 at 12:58 PM, Joe Berkovitz <joe@noteflight.com>
> wrote:
>
> Fabulous -- thank you so much for landing this!
>
>
>
> About V1 Blocker issues: what he said :-)
>
>
> .            .       .    .  . ...Joe
>
> Joe Berkovitz
> Founder
> Noteflight LLC
>
> 49R Day Street
> <https://maps.google.com/?q=49R+Day+Street+Somerville+MA+02144+USA&entry=gmail&source=g>
> Somerville MA 02144
> <https://maps.google.com/?q=49R+Day+Street+Somerville+MA+02144+USA&entry=gmail&source=g>
> USA
> <https://maps.google.com/?q=49R+Day+Street+Somerville+MA+02144+USA&entry=gmail&source=g>
>
> "Bring music to life"
> www.noteflight.com
>
>
>
> On Wed, Sep 20, 2017 at 12:46 PM, Raymond Toy <rtoy@google.com> wrote:
>
> Thanks to the reviewers for taking a look!
>
>
>
> The changes have been merged and are now live.  Just in case, I added a
> tag, pre-conversion-to-contiguous-idl, to mark the point just before the
> merge so we can go back and look at the old version in case we notice
> something is missing or changed inadvertently.
>
>
>
> So now you have no excuse for fixing all the outstanding v1 blocker
> issues! ;-)
>
>
>
> On Mon, Sep 18, 2017 at 2:59 PM, Jerry Smith (WPT) <jdsmith@microsoft.com>
> wrote:
>
> I just went through the WebIDL as well.  I posted three comments, but
> suspect 2 of the 3 things I noted were intentional.  The other is a small
> unrelated typo.
>
>
>
> *From:* Raymond Toy [mailto:rtoy@google.com]
> *Sent:* Monday, September 18, 2017 10:54 AM
> *To:* Joe Berkovitz <joe@noteflight.com>
> *Cc:* Audio Working Group <public-audio@w3.org>
> *Subject:* Re: review of contiguous IDL
>
>
>
> Thanks for the review.
>
>
>
> My current plan is to merge this to hte main branch on Wed morning
> (2017-09-20). Any remaining issues with the conversion will be fixed
> afterwards.
>
>
>
> So if you want to make comments, please review before Wed morning (PDT
> time).
>
>
>
> On Thu, Sep 14, 2017 at 3:04 PM, Joe Berkovitz <joe@noteflight.com> wrote:
>
> Hi Raymond,
>
>
>
> It turns out that I was able to get to this earlier than expected.
>
>
>
> I only found one missing thing in the updated version, described here:
>
>
>
>     https://github.com/WebAudio/web-audio-api/pull/1290#
> pullrequestreview-62899714
>
>
>
> All other content has carried over.
>
>
>
> Best,
>
> .            .       .    .  . ...Joe
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
Received on Thursday, 21 September 2017 13:04:23 UTC

This archive was generated by hypermail 2.3.1 : Thursday, 21 September 2017 13:04:24 UTC