Re: Pull Request Review

On Sun, Jul 31, 2016 at 9:53 AM, Joe Berkovitz <joe@noteflight.com> wrote:

> Dear Spec Editors,
>
> I've finished reviewing all the outstanding pull requests at
> https://github.com/WebAudio/web-audio-api/pulls?q=is%3Apr+is%3Aopen+sort%3Acreated-asc
> and added comments and (in most cases) an approval. Thanks for the great
> work in putting all these changes together.
>

Thanks for reviewing all of these.  Most of them have landed, but a several
need WG review on exactly what we want to do.  They are fairly minor
changes, but they need discussion on what to do.

In particular:

https://github.com/WebAudio/web-audio-api/pull/889 needs a decision on what
the name of the option is for disabling normalization.

https://github.com/WebAudio/web-audio-api/pull/890 suggests adding a new
read-only attribute to the DelayNode for the maxDelayTime that is a
construction parameter.

Finally, I noticed I missed constructors for AudioBuffer and
AudioBufferSource; I'll add these soon.



>
> With September rapidly approaching, please try to keep these PRs moving
> into the spec as most of them are either ready to go or only require very
> little adjustment.
>
> I did find one non-trivial issue that I marked as "Needs WG Review": there
> appears to be some confusion over the exact behavior of suspend(), noted in
> a new issue https://github.com/WebAudio/web-audio-api/issues/919
>
> Best,
> .            .       .    .  . ...Joe
>
> Joe Berkovitz
> President
> Noteflight LLC
>
> +1 978 314 6271
>
> 49R Day Street
> Somerville MA 02144
> USA
>
> "Bring music to life"
> www.noteflight.com
>