W3C home > Mailing lists > Public > public-audio@w3.org > October to December 2012

Re: [Bug 20254] Add code examples

From: James Ingram <j.ingram@netcologne.de>
Date: Mon, 10 Dec 2012 22:57:59 +0100
Message-ID: <50C65AE7.4050205@netcologne.de>
To: public-audio@w3.org, Chris Wilson <cwilso@google.com>, Jussi Kalliokoski <jussi.kalliokoski@gmail.com>, Florian Bomers <w3c_bugz@bome.com>
Hi Chris, all,

Thanks from me too for the super fast changes. :-)

The thing that sparked my remark about a "global MIDIAccess object" was 
the comment in the first code lines of both 9.1 and 9.5 ( // global 
MIDIAccess object ). I should have made that clearer. Its not MIDIAccess 
that's global, so I just found the comment confusing. I think you could 
simply replace the word 'global' there by something else. Maybe 'saved' 
or 'cached'...

Just noticed that the global 'midi' variable is not used at all in 9.5. 
You could either assign to it and use it in onMIDISuccess() or delete it 
altogether.

All the best,
James
Received on Monday, 10 December 2012 22:00:32 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 21:50:03 UTC