Re: Working Group Last Call: HTTP/2 revision

On Fri, Jul 23, 2021 at 05:13:28PM +1000, Martin Thomson wrote:
> Hi Willy,
> 
> How does this look?  https://github.com/httpwg/http2-spec/pull/877
> 
> I agree that this was getting a bit unwieldy.  It's nice to have it all
> spelled out, but we ended up with a lot of independent fields.   A little
> vertical space does seem to help with readability.

Yep, our messages have crossed, but as I responded there I agree it's already
significantly better. I think for the flags, which are fixed in a single byte
and already specified with their hex value, we could write the value in front
of the bit(s), like this:

  DATA Frame {
    Length (24),
    Type (8) = 0,

    Unused Flags (4),    // 0xF0
    PADDED Flag (1),     // 0x08
    Unused Flags (2),    // 0x06
    END_STREAM Flag (1), // 0x01

    Reserved (1),
    Stream Identifier (31),
    [Pad Length (8)],
    Data (..),
    Padding (..),
  }

I've found myself many times having to scan the text of 7540 to figure a
bit value, and having them there would definitely help IMHO.

Thank you!
Willy

Received on Friday, 23 July 2021 07:23:33 UTC