W3C home > Mailing lists > Public > ietf-http-wg@w3.org > July to September 2010

Re: rewritten section on message body and length

From: Willy Tarreau <w@1wt.eu>
Date: Wed, 28 Jul 2010 07:50:03 +0200
To: "Roy T. Fielding" <fielding@gbiv.com>
Cc: HTTP Working Group <ietf-http-wg@w3.org>
Message-ID: <20100728055003.GC23078@1wt.eu>
On Tue, Jul 27, 2010 at 08:52:39PM -0700, Roy T. Fielding wrote:
> As part of the changes for draft 11, I merged the misnamed section on
> message length into the message body section and then rewrote the
> steps for determining the message body length to remove the
> ambiguities noted previously in tickets #28, #90, and #95.

This rewording is really good. It clarifies the fact that content-length
or T-E are recommended even in case of "connection: close" (some servers
still don't emit them in such a case, Tomcat was fixed just a few weeks
ago). It clarifies the handling of body requests which could have been
complex for gateways because it was not perfectly clear what to do with
the body for unknown methods. Now it's clear. The expected behavious on
multiple content-length issue is clearly stated, so that looks fine to
me. It is good that you have put a sentence about smuggling attacks, it
will make implementors be more careful as it's not just a matter of
compatibility with broken implementations. This section has always been
one of the most sensible ones of the spec for me and now it appears
very clear.

I just have one comment on the block below :

>    3.  If a message is received without Transfer-Encoding and with
>        either multiple Content-Length header fields or a single Content-
>        Length header field with an invalid value, then the message
>        framing is invalid and MUST be treated as an error to prevent
>        request or response smuggling.  If this is a request message, the
>        server MUST respond with a 400 (Bad Request) status code and then
>        close the connection.  If this is a response message received by
>        a proxy or gateway, the proxy or gateway MUST discard the
>        received response, send a 502 (Bad Gateway) status code as its
>        downstream response, and then close the connection.  If this is a
>        response message received by a user-agent, the message-body
>        length is determined by reading the connection until it is
>        closed; an error SHOULD be indicated to the user.

On rare occasions, I have observed duplicated content-length headers
in tcpdump captures. For this reason, I made the choice in haproxy to
only accept them if *all* values are equal. I seem to remember that
Squid considers the max of them (which covers any possible smuggling)
and forwards only this one.

Do you think that such behaviours should now be changed (due to the
"MUST" above), at the risk of occasionally blocking responses ? I'm
asking because the user-agent does not have as strict a requirement,
and when you deploy a proxy or gateway somewhere and that some 502
start to appear, users yell that the implementation is buggy because
it worked without it due to the fact that the U-A was more tolerant
(very common). So in my opinion, either we should make the U-A reject
the incorrect response (in order to get buggy apps fixed), or we may
relax the check for proxies and gateways in a responsible way (both
behaviours described above seem efficient).

Thanks,
Willy
Received on Wednesday, 28 July 2010 05:50:36 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 27 April 2012 06:51:23 GMT