W3C home > Mailing lists > Public > html-tidy@w3.org > October to December 2000

Re: HTML Tidy 4aug00 crashes on solaris

From: Dave Raggett <dsr@w3.org>
Date: Mon, 6 Nov 2000 14:15:53 +0000 (GMT Standard Time)
To: Ian Holsman <ianholsman@iname.com>
cc: html-tidy@w3.org, gerald@w3.org
Message-ID: <Pine.WNT.4.10.10011061414010.-343577@hazel>
On Fri, 3 Nov 2000, Ian Holsman wrote:

> the URL in question is http://www.cnetinvestor.com (attached)
> the line (48) in question which crashes it is:
> 
> <spanstyle="color:#FFCC00">
> 
> in localise.c 216 .. where is doesn't check if attr is null
> 
> my fix is the following
> 
>   else if (code == BAD_ATTRIBUTE_VALUE)
>        {
>            tidy_out(lexer->errout, "Warning: ");
>            ReportTag(lexer, node);
>            if (attr)
>              tidy_out(lexer->errout, " unknown attribute value \"%s\"", 
> attr);
>            else
>              tidy_out(lexer->errout, " unknown attribute value 
> \"(null)\"" );
>        }
> 
> which is a kludge .. but does the job (for now)
> ..Ian

Thanks. I am rather behind on the next release, but it is coming!
I too have kludged this with a test at the start of the function
that sets attr to "???" if it is found to be null. This works for
all errors and not just for BAD_ATTRIBUTE_VALUE.

Regards,

-- Dave Raggett <dsr@w3.org> http://www.w3.org/People/Raggett
tel/fax: +44 122 578 3011 (or 2521) +44 771 213 7629 (mobile)
World Wide Web Consortium (on assignment from Phone.com)
Received on Monday, 6 November 2000 09:16:04 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Tuesday, 3 April 2012 06:13:44 GMT