W3C home > Mailing lists > Public > html-tidy@w3.org > January to March 2000

[FIX] Tidy wraps attributes when told not to

From: J. David Bryan <dbryan@bcpl.net>
Date: Fri, 24 Mar 2000 11:45:40 -0600
To: HTML Tidy List <html-tidy@w3.org>
Message-ID: <OF0D507A24.2BB2F31E-ON86256877.003EB9FA@rfdinc.com>

    Further to my report of 22 January, it appears that the reason Tidy
wraps when it shouldn't is a problem in lines 682-683 of "pprint.c":

  else if (!attr->dict->nowrap || WrapAttVals)
      wrappable = yes;

If I understand this correctly, it means that wrapping of attributes is
performed if the internal "wrapping is prohibited" flag is not set or the
user has asked for wrapping.  However, I think the logic should be that
wrapping is performed if the internal "wrapping is prohibited" flag is not
set AND the user has asked for wrapping.  In other words, if the user says,
"don't wrap," then wrapping should not be allowed.

I think this change fixes the problem:

  else if (!attr->dict->nowrap && WrapAttVals)
      wrappable = yes;



                                      -- Dave
Received on Friday, 24 March 2000 13:14:14 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Tuesday, 3 April 2012 06:13:43 GMT